[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 2/3] xen netback: add fault injection facility
- To: Juergen Gross <jgross@xxxxxxxx>
- From: <staskins@xxxxxxxxxx>
- Date: Fri, 20 Apr 2018 15:02:35 +0200
- Cc: jakub.kicinski@xxxxxxxxxxxxx, mcroce@xxxxxxxxxx, hpa@xxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, daniel@xxxxxxxxxxxxx, x86@xxxxxxxxxx, mingo@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, paul.durrant@xxxxxxxxxx, stefanha@xxxxxxxxxx, dsa@xxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, ggarcia@xxxxxxxxxxxx, axboe@xxxxxxxxx, amir.jer.levy@xxxxxxxxx, wei.liu2@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, dwmw@xxxxxxxxxxxx, roger.pau@xxxxxxxxxx
- Delivery-date: Fri, 20 Apr 2018 13:02:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/20/18 15:00, Juergen Gross wrote:
On 20/04/18 14:52, staskins@xxxxxxxxxx wrote:
On 04/20/18 13:25, Juergen Gross wrote:
On 20/04/18 12:47, Stanislav Kinsburskii wrote:
+ for (fi = 0; fi < XENVIF_FI_MAX; fi++) {
+ vfi->faults[fi] = xen_fi_dir_add(vfi->dir,
+ xenvif_fi_names[fi]);
How does this work? xenvif_fi_names[] is an empty array and this is the
only reference to it. Who is allocating the memory for that array?
Well, it works in the way one adds a var to enum (which is used as a key
later) and a corresponding string into the array (which is used as a
name for the fault directory in sysfs).
Then you should size the array via XENVIF_FI_MAX.
Makes sense.
Thanks!
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
