[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/3] xen netback: add fault injection facility

On 04/20/18 15:00, Juergen Gross wrote:
On 20/04/18 14:52, staskins@xxxxxxxxxx wrote:
On 04/20/18 13:25, Juergen Gross wrote:
On 20/04/18 12:47, Stanislav Kinsburskii wrote:
+    for (fi = 0; fi < XENVIF_FI_MAX; fi++) {
+        vfi->faults[fi] = xen_fi_dir_add(vfi->dir,
+                xenvif_fi_names[fi]);
How does this work? xenvif_fi_names[] is an empty array and this is the
only reference to it. Who is allocating the memory for that array?
Well, it works in the way one adds a var to enum (which is used as a key
later) and a corresponding string into the array (which is used as a
name for the fault directory in sysfs).
Then you should size the array via XENVIF_FI_MAX.

Makes sense.

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.