[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: correct assertion in destroy_perdomain_mapping()



On 20/04/18 16:03, Jan Beulich wrote:
> hvm_domain_initialise() may call this with nr being zero, which triggers
> the "does not cross L3 boundary" check.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Is this the correct fix?

Its unclear what the call to create_perdomain_mapping() is doing, but it
is the sole caller which passes 0.

I presume it is to allocate d->arch.perdomain_l3_pg but
destroy_perdomain_mapping() doesn't free this page, so I've got no idea
what the destroy call is trying to achieve.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.