[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/8] x86/SVM: Add AVIC vmexit handlers

On 4/17/2018 7:58 AM, Jan Beulich wrote:
On 04.04.18 at 01:01, <Janakarajan.Natarajan@xxxxxxx> wrote:
--- a/xen/include/asm-x86/hvm/vlapic.h
+++ b/xen/include/asm-x86/hvm/vlapic.h
@@ -137,6 +137,10 @@ void vlapic_ipi(struct vlapic *vlapic, uint32_t icr_low,
uint32_t icr_high);
int vlapic_apicv_write(struct vcpu *v, unsigned int offset); +void vlapic_reg_write(struct vcpu *v, unsigned int offset, uint32_t val);
+uint32_t vlapic_read_aligned(const struct vlapic *vlapic, unsigned int offset);
If making these non-static is really necessary, they should (name-wise) become
proper pairs of one another, e.g. renamed the former to vlapic_reg_read().

Also while here you properly use uint32_t, almost everywhere you use u32.
Please switch this throughout the series, and of course for all other fixed
width integer types.

In the case of vmcb.h, where the existing variables use u32, u64 would you want me to have uint32_t,
uint64_t for the new avic variables?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.