Re: [Xen-devel] [PATCH 3/3] xen blkback: add fault injection facility

[kbuild test robot <lkp@xxxxxxxxx>]

Hi Stanislav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Stanislav-Kinsburskii/Introduce-Xen-fault-injection-facility/20180422-201946
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/block//xen-blkback/blkback_fi.c: In function 'xen_blkif_fi_init':
>> drivers/block//xen-blkback/blkback_fi.c:87:51: error: dereferencing pointer 
>> to incomplete type 'struct backend_info'
     bfi->dir = debugfs_create_dir(dev_name(&blkif->be->dev->dev),
                                                      ^~

vim +87 drivers/block//xen-blkback/blkback_fi.c

    77  
    78  int xen_blkif_fi_init(struct xen_blkif *blkif)
    79  {
    80          struct xen_blkif_fi *bfi;
    81          int fi, err = -ENOMEM;
    82  
    83          bfi = kmalloc(sizeof(*bfi), GFP_KERNEL);
    84          if (!bfi)
    85                  return -ENOMEM;
    86  
  > 87          bfi->dir = debugfs_create_dir(dev_name(&blkif->be->dev->dev),
    88                                        blkif_fi_dir);
    89          if (!bfi->dir)
    90                  goto err_dir;
    91  
    92          for (fi = 0; fi < XENBLKIF_FI_MAX; fi++) {
    93                  bfi->faults[fi] = xen_fi_dir_add(bfi->dir,
    94                                                   
xen_blkif_fi_names[fi]);
    95                  if (!bfi->faults[fi])
    96                          goto err_fault;
    97          }
    98  
    99          blkif->fi_info = bfi;
   100          return 0;
   101  
   102  err_fault:
   103          for (; fi > 0; fi--)
   104                  xen_fi_del(bfi->faults[fi]);
   105          debugfs_remove_recursive(bfi->dir);
   106  err_dir:
   107          kfree(bfi);
   108          return err;
   109  }
   110  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel