[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 07/10] passthrough/amd: split out hvm code from iommu_map.c

>>> On 21.02.18 at 22:46, <wei.liu2@xxxxxxxxxx> wrote:
> Move and rename update_paging_mode. Create a local header file for
> this and other functions that need exporting.

Functions you move into global name space need suitable prefixes - neither
hvm_update_paging_mode() nor set_iommu_pde_present() clarify that this
is AMD IOMMU specific code.

Also please don't have bool_t or things like u32 in new code you add (here:
the set_iommu_pde_present() prototype).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.