Re: [Xen-devel] [PATCH for-4.11] x86/spec_ctrl: Updates to retpoline-safety decision making

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/04/2018 22:16, Konrad Rzeszutek Wilk wrote:
>> diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
>> index 5b5ec90..aff06f0 100644
>> --- a/xen/arch/x86/spec_ctrl.c
>> +++ b/xen/arch/x86/spec_ctrl.c
>> @@ -113,12 +113,13 @@ static void __init print_details(enum ind_thunk thunk)
>>      printk(XENLOG_DEBUG "Speculative mitigation facilities:\n");
>>  
>>      /* Hardware features which pertain to speculative mitigations. */
>> -    printk(XENLOG_DEBUG "  Hardware features:%s%s%s%s%s\n",
>> +    printk(XENLOG_DEBUG "  Hardware features:%s%s%s%s%s%s\n",
>>             (_7d0 & cpufeat_mask(X86_FEATURE_IBRSB)) ? " IBRS/IBPB" : "",
>>             (_7d0 & cpufeat_mask(X86_FEATURE_STIBP)) ? " STIBP"     : "",
>>             (e8b  & cpufeat_mask(X86_FEATURE_IBPB))  ? " IBPB"      : "",
>>             (caps & ARCH_CAPABILITIES_IBRS_ALL)      ? " IBRS_ALL"  : "",
>> -           (caps & ARCH_CAPABILITIES_RDCL_NO)       ? " RDCL_NO"   : "");
>> +           (caps & ARCH_CAPABILITIES_RDCL_NO)       ? " RDCL_NO"   : "",
>> +           (caps & ARCH_CAPS_RSBA)                  ? " RBSA"      : "");
> You have RSBA on the left and RBSA on the right. Which one is it?

Bah - these are impossible acronyms to type.  It is RSB-Alternative, so
the LHS is correct and I'll submit a correction for the RHS.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel