Re: [Xen-devel] [PATCH v2 1/5] ALSA: xen-front: Introduce Xen para-virtualized sound frontend driver

[Takashi Iwai <tiwai@xxxxxxx>]

On Mon, 16 Apr 2018 08:24:49 +0200,
Oleksandr Andrushchenko wrote:
> --- /dev/null
> +++ b/sound/xen/Kconfig
> @@ -0,0 +1,10 @@
> +# ALSA Xen drivers
> +
> +config SND_XEN_FRONTEND
> +     tristate "Xen para-virtualized sound frontend driver"
> +     depends on XEN && SND_PCM

Please do select SND_PCM instead of depends.

> +     select XEN_XENBUS_FRONTEND
> +     default n

"default n" is superfluous, drop it.


thanks,

Takashi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel