Re: [Xen-devel] [PATCH 5/7] doc: correct livepatch.markdown syntax

[Juergen Gross <jgross@xxxxxxxx>]

On 26/04/18 17:12, Konrad Rzeszutek Wilk wrote:
> On Tue, Apr 24, 2018 at 08:44:57AM +0200, Juergen Gross wrote:
>> "make -C docs all" fails due to incorrect markdown syntax in
>> livepatch.markdown. Correct it.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>>  docs/misc/livepatch.markdown | 589 
>> ++++++++++++++++++++-----------------------
>>  1 file changed, 272 insertions(+), 317 deletions(-)
>>
>> diff --git a/docs/misc/livepatch.markdown b/docs/misc/livepatch.markdown
>> index 54a6b850cb..f3c1320e5a 100644
>> --- a/docs/misc/livepatch.markdown
>> +++ b/docs/misc/livepatch.markdown
>> @@ -89,33 +89,26 @@ As example we will assume the hypervisor does not have 
>> XSA-132 (see
>>  4ff3449f0e9d175ceb9551d3f2aecb59273f639d) and we would like to binary patch
>>  the hypervisor with it. The original code looks as so:
>>  
>> -<pre>
>> -   48 89 e0                  mov    %rsp,%rax  
>> -   48 25 00 80 ff ff         and    $0xffffffffffff8000,%rax  
>> -</pre>
>> +       48 89 e0                  mov    %rsp,%rax  
>> +       48 25 00 80 ff ff         and    $0xffffffffffff8000,%rax  
>>  
>>  while the new patched hypervisor would be:
>>  
>> -<pre>
>> -   48 c7 45 b8 00 00 00 00   movq   $0x0,-0x48(%rbp)  
>> -   48 c7 45 c0 00 00 00 00   movq   $0x0,-0x40(%rbp)  
>> -   48 c7 45 c8 00 00 00 00   movq   $0x0,-0x38(%rbp)  
>> -   48 89 e0                  mov    %rsp,%rax  
>> -   48 25 00 80 ff ff         and    $0xffffffffffff8000,%rax  
>> -</pre>
>> +       48 c7 45 c0 00 00 00 00   movq   $0x0,-0x40(%rbp)  
> 
> How come you deleted:
> 
> 48 c7 45 b8 00 00 00 00   movq   $0x0,-0x48(%rbp)
> ?
> 
> It is OK, but I am just curious.

Oh, sorry. Thanks for noticing. I'll add it back.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel