Re: [Xen-devel] [PATCH RESEND v1 1/7] x86: add a flag to enable Intel processor trace

["Kang, Luwei" <luwei.kang@xxxxxxxxx>]

> > diff --git a/docs/misc/xen-command-line.markdown
> > b/docs/misc/xen-command-line.markdown
> > index 781110d..95411cf 100644
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -1009,6 +1009,13 @@ debug hypervisor only).
> >  ### idle\_latency\_factor
> >  > `= <integer>`
> >
> > +### intel\_pt
> > +> `= <boolean>`
> > +
> > +> Default: `true`
> > +
> 
> After reading the manual a bit I think this option needs to be more
> sophisticated.
> 
> The series only implements guest-only tracing, while in the future we might
> want host-only tracing and system wide tracing.
> 
> Even the other modes aren't implemented yet we should leave room for
> them.
> 

Hi Wei,
     Thanks for the review. So what about define guest mode like this and make 
the option as a string. Other mode can be added like 'system | host' in future.

### Intel\_pt
> `= guest`

<some description>

By the way, you mentioned in another said that,  "No document for this option 
here?". Do you mean the description is too simple in this patch or I need add 
some words in a another document?

Thanks,
Luwei Kang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel