[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: char: Remove unnecessary (uart->irq > 0) check


On 30/04/18 09:19, Jan Beulich wrote:
On 28.04.18 at 11:08, <amittomer25@xxxxxxxxx> wrote:
While working on MVEBU uart driver, Julien pointed out that (uart->irq > 0)
check is unnecessary during irq set up.if ever there is an invalid irq, driver
initialization itself would be bailed out from platform_get_irq.

This patch would remove similar check for other uart drivers present in XEN.

At the example of the changes to ns16550.c you do, this is not correct. I
can't judge about the various ARM specific drivers, but the 16550 can well
be run in polling mode, and hence failure to set up an interrupt is not fatal
to overall driver initialization.

This makes sense for any ARM only UART driver because they don't support polling. However, I agree that if the driver is supporting polling (such as NS16550) then you should keep the irq check around.


Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
     * This patch is only compiled tested.

In which case this should be marked RFC imo.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.