Re: [Xen-devel] [PATCH v2 1/2] SVM: re-work VMCB sync-ing

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.04.18 at 17:30, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 04/30/2018 07:37 AM, Jan Beulich wrote:
>> @@ -1168,6 +1169,9 @@ static void noreturn svm_do_resume(struc
>>  
>>      hvm_do_resume(v);
>>  
>> +    if ( v->arch.hvm_svm.vmcb_sync_state == vmcb_needs_vmload )
>> +        svm_sync_vmcb(v, vmcb_needs_vmsave);
> 
> 
> Is it not possible (or advisable) to move the test into svm_sync_vmcb()
> (and drop the ASSERT there)?

It is possible; I'm not sure myself if it's advisable, but I take you asking the
question as you thinking it is, so I'll change it.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel