Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 01/05/2018, 16:16, "Ian Jackson" <ian.jackson@xxxxxxxxxx> wrote:

    Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl 
script to optimise the workflow when using git format-patch with 
get_maintainer.pl"):
    > In the cover letter, the tool always insert at the top as it is a 
transient
    > thing that does not end up in git.
    > 
    > On 01/05/2018, 13:52, "Ian Jackson" <ian.jackson@xxxxxxxxxx> wrote:
    >
    >     As an aside, I guess with `-i ccbody' your tool still puts the CCs in
    >     the mail headers of the cover letter ?  Or will git-send-email do 
that ?
    > 
    > git-send-email does that.
    
    These replies seem to be contradictory.

That's because I mis-read the question. So the correct answer is:
the tool does that. But it does this regardless of -i *

    Also, IIRC someone wrote earlier in the thread that they prefer the
    practice of including CCs in the body of the cover letter too.  So
    assuming that the first reply is accurate, it may not be desirable.

That can be done easily. Maybe the best way to approach this is
to have two options that control how CCs are inserted into the cover
letter and a separate one that controls how CCs are inserted into
patches.

In that case I would probably rename 
--insert | -i to --insert-patch | -p with top, ccbody, none as admissible values
and
--insert-cover | -c with top, ccbody, none as admissible values


Cheers
Lars


In 

Lars
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel