[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH 4/4] Standalone HostFlags: Use ^ for negation, not !



The ! here doesn't cause any shell rune trouble in, but we want to
move to using ^ everywhere for consistency.

We still honour ! to support old configs.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 Osstest/HostDB/Static.pm | 2 +-
 README                   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Osstest/HostDB/Static.pm b/Osstest/HostDB/Static.pm
index 3191c56..ab9542d 100644
--- a/Osstest/HostDB/Static.pm
+++ b/Osstest/HostDB/Static.pm
@@ -56,7 +56,7 @@ sub get_flags ($$) { #method
        return unless defined $str;
        foreach my $fl (split /[ \t,;]+/, $str) {
            next unless length $fl;
-           if ($fl =~ s/^\!//) {
+           if ($fl =~ s/^[!^]//) {
                delete $flags->{$fl};
            } else {
                $flags->{$fl} = 1;
diff --git a/README b/README
index 9d97c61..7b7bc52 100644
--- a/README
+++ b/README
@@ -447,7 +447,7 @@ HostProp_<testbox>_NtpServer
 HostFlags_<testbox>
    Defines a set of flags for the host. Flags is a list separated by
    whitespace, comma or semi-colon. A flag can be unset by prepending
-   a !. Only used in standalone mode.
+   a ^ (or !). Only used in standalone mode.
 
 HostGroup_<testbox> <group>
    Defines a group of similar hosts of which <testbox> is a
@@ -488,7 +488,7 @@ TestHost
 HostProp_<property>
 HostProp_<host>_<property>
 HostFlags                flag,flag,flag,...
-HostFlags_<host>         flag,!flag,!flag,flag...
+HostFlags_<host>         flag,^flag,^flag,flag...
 
 HostProp_DhcpWatchMethod
    leases <format> <source>
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.