Re: [Xen-devel] [PATCH v3 0/2] SVM: guest state handling adjustments

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 04/05/18 16:07, Jan Beulich wrote:
> Only patch 1 is clearly meant for 4.11. The second patch, however, eliminates
> a (theoretical) window the first patch still leaves, so should at least be 
> considered.
> Furthermore previous discussion suggests that it might even be desirable to 
> fold
> both patches into one (or swap their order).
>
> 1: re-work VMCB sync-ing
> 2: introduce a VM entry helper
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

As this is fixing a real bug and we're getting quite late in 4.11 at
this point, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I'm still not happy with the API, and especially that
"svm_sync_vmcb(curr, vmcb_needs_vmsave);" in patch two does not do the
intuitive thing.  That said, I'm going to need to rewrite this anyway in
4.12 to get the MSR infrastructure working, so this code isn't going to
stay long.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel