[Xen-devel] [OSSTEST PATCH] ts-xen-build: run `make all' before `make', by default

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

The Xen build system has some quirks.  One of them is that `make' is a
version of `make dist' which is a version of `make install', which
runs `make install' in each subdir - but there are subdirs where `make
install' is a no-op which does not depend on `make all'.  Perhaps the
latter is a mistake, but it's not one we can correct in stable
branches.

The result is that we might miss bugs where `make all' fails.  Eg, the
recently discovered build failures in the emulator tests, due to
backported changes.

Detect these by running `make all' before `make' (unless our caller
has specified some other build arguments).  In the future perhaps we
should do tools and hypervisor builds entirely separately.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 ts-xen-build | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ts-xen-build b/ts-xen-build
index c5d2a1d..018bc6a 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -160,6 +160,12 @@ END
             fi
 END
 
+    if (!@make_args) {
+       buildcmd_stamped_logged(9000, 'xen', 'all', '',<<END,'');
+            $make_prefix make $makeflags all
+END
+    }
+
     buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
             $make_prefix make $makeflags @make_args
 END
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel