Re: [Xen-devel] [PATCH 03/10] x86/spec_ctrl: Merge bti_ist_info and use_shadow_spec_ctrl into spec_ctrl_flags

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 11, 2018 at 11:38:07AM +0100, Andrew Cooper wrote:
> All 3 bits of information here are control flags for the entry/exit code
> behaviour.  Treat them as such, rather than having two different variables.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This patch does what it says on the tin.

FWIW:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> diff --git a/xen/include/asm-x86/spec_ctrl_asm.h 
> b/xen/include/asm-x86/spec_ctrl_asm.h
> index e8e8f9a..97da08b 100644
> --- a/xen/include/asm-x86/spec_ctrl_asm.h
> +++ b/xen/include/asm-x86/spec_ctrl_asm.h
> @@ -20,9 +20,10 @@
>  #ifndef __X86_SPEC_CTRL_ASM_H__
>  #define __X86_SPEC_CTRL_ASM_H__
>  
> -/* Encoding of the bottom bits in cpuinfo.bti_ist_info */
> -#define BTI_IST_WRMSR (1 << 1)
> -#define BTI_IST_RSB   (1 << 2)
> +/* Encoding of cpuinfo.spec_ctrl_flags */
> +#define SCF_use_shadow (1 << 0)
> +#define SCF_ist_wrmsr  (1 << 1)
> +#define SCF_ist_rsb    (1 << 2)
>  

Fancy turning them into 1u << X while you're at it?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel