Re: [Xen-devel] [PATCH RFC 1/7] xen: Introduce XEN_COMPILE_POSIX_TIME

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Mon, May 14, 2018 at 04:30:02AM -0600, Jan Beulich wrote:
> >>> On 08.05.18 at 14:18, <daniel.kiper@xxxxxxxxxx> wrote:
> > On Mon, Apr 30, 2018 at 09:56:38AM -0600, Jan Beulich wrote:
> >> >>> On 08.07.17 at 23:53, <daniel.kiper@xxxxxxxxxx> wrote:
> >> > @@ -164,6 +165,7 @@ delete-unfresh-files:
> >> >  include/xen/compile.h: include/xen/compile.h.in .banner
> >> >          @sed -e 's/@@date@@/$(XEN_BUILD_DATE)/g' \
> >> >              -e 's/@@time@@/$(XEN_BUILD_TIME)/g' \
> >> > +            -e 's/@@posix_time@@/$(XEN_BUILD_POSIX_TIME)/g' \
> >>
> >> In order to fill a PE header, do you really need to make this available in
> >> compile.h?
> >
> > Why not? I think that we should have all time related constants defined
> > in one place. Even if one of them is used just only once.
>
> I don't think so, fwiw, i.e. I'd prefer you to consume XEN_BUILD_{DATE,TIME}
> at the point/place you want/need the time in POSIX form.

That would be perfect but TimeDateStamp in PE header requires the number of
seconds since the epoch. And XEN_BUILD_{DATE,TIME} are in different formats.
Hence, what should I do then?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel