Re: [Xen-devel] [PATCH] tools/ocaml/libs/xc fix gcc-8 format-truncation warning

[Juergen Gross <jgross@xxxxxxxx>]

On 15/05/18 15:19, Wei Liu wrote:
> CC Juergen, I think this should be in 4.11
> 
> On Tue, May 15, 2018 at 11:48:43AM +1000, John Thomson wrote:
>>  CC       xenctrl_stubs.o
>> xenctrl_stubs.c: In function 'failwith_xc':
>> xenctrl_stubs.c:65:17: error: 'snprintf' output may be truncated before the 
>> last format character [-Werror=format-truncation=]
>>       "%d: %s: %s", error->code,
>>                  ^
>> xenctrl_stubs.c:64:4: note: 'snprintf' output 6 or more bytes (assuming 
>> 1029) into a destination of size 1028
>>     snprintf(error_str, sizeof(error_str),
>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>       "%d: %s: %s", error->code,
>>       ~~~~~~~~~~~~~~~~~~~~~~~~~~
>>       xc_error_code_to_desc(error->code),
>>       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>       error->message);
>>       ~~~~~~~~~~~~~~~
>> cc1: all warnings being treated as errors
>> make[8]: *** 
>> [/build/xen-git/src/xen/tools/ocaml/libs/xc/../../Makefile.rules:37: 
>> xenctrl_stubs.o] Error 1
>> m
>>
>> Signed-off-by: John Thomson <git@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Release-acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel