Re: [Xen-devel] [PATCH v2 07/10] x86/SVM: Add interrupt management code via AVIC

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.05.18 at 23:07, <Janakarajan.Natarajan@xxxxxxx> wrote:
> +void svm_avic_deliver_posted_intr(struct vcpu *v, u8 vec)
> +{
> +    struct vlapic *vlapic = vcpu_vlapic(v);
> +
> +    /* Fallback to use non-AVIC if vcpu is not enabled with AVIC. */
> +    if ( !svm_avic_vcpu_enabled(v) )
> +    {
> +        if ( !vlapic_test_and_set_vector(vec, &vlapic->regs->data[APIC_IRR]) 
> )
> +            vcpu_kick(v);
> +        return;
> +    }
> +
> +    /* If interrupt is disabled, do not ignore the interrupt */
> +    if ( !(guest_cpu_user_regs()->eflags & X86_EFLAGS_IF) )
> +        return;

It seems to me that I did comment on this before - I don't think EFLAGS.IF
should be considered here:

> +    if ( vlapic_test_and_set_vector(vec, &vlapic->regs->data[APIC_IRR]) )
> +        return;

Latching the interrupt into IRR ought to keep it pending until the guest sets
EFLAGS.IF again.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel