Re: [Xen-devel] [xen-unstable-smoke baseline test] 122919: tolerable all pass

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

osstest service owner writes ("[xen-unstable-smoke baseline test] 122919: 
tolerable all pass"):
> "Old" tested version had not actually been tested; therefore in this
> flight we test it, rather than a new candidate.  The baseline, if
> any, is the most recent actually tested revision.

This is a lie.  In fact, the problem is that many of these flights are
rather ill-constructed.  I have just force pushed the commit below to
osstest to fix it.

Ian.

From 86662216840ce20c2e6dd248e4a04492d11b27dd Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Fri, 18 May 2018 13:42:13 +0000
Subject: [OSSTEST PATCH] mg-adjust-flight-makexrefs: Repair after "Use ^ for
 excluding jobs"

In
  3b433e39382b13dda5d25aebecaf4864ef69c8d4
  "mg-adjust-flight-makexrefs: Use ^ for excluding jobs, not !"
a shell glob pattern was changed:
  -    !*)    ifmatch=$tokeep; action=$todelete ; glob="${glob#!}" ;;
  +    [!^]*) ifmatch=$tokeep; action=$todelete ; glob="${glob#?}" ;;

But in globbing, ! inside [ ] is a character class complement, not a
literal.  The result is that mg-adjust-flight-makexrefs would
generally replace jobs willy-nilly.

Fix this by using two separate glob patterns, and no character class.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 mg-adjust-flight-makexrefs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mg-adjust-flight-makexrefs b/mg-adjust-flight-makexrefs
index 16a0d98..e3716c4 100755
--- a/mg-adjust-flight-makexrefs
+++ b/mg-adjust-flight-makexrefs
@@ -60,7 +60,7 @@ for j in `./cs-adjust-flight $flight jobs-list '^build-'`; do
 
        for glob in $keepjobs; do
                case "$glob" in
-               [!^]*) ifmatch=$tokeep; action=$todelete ; glob="${glob#?}" ;;
+               ^*|!*) ifmatch=$tokeep; action=$todelete ; glob="${glob#?}" ;;
                *)  ifmatch=$todelete; action=$tokeep ;;
                esac
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel