Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 18, 2018 at 09:25:07AM +0200, Juergen Gross wrote:
> On 17/05/18 17:51, Olaf Hering wrote:
> > If a domU has a qemu-xen instance attached, it is required to call qemus
> > "xen-save-devices-state" method. Without it, the receiving side of a PV
> > migration may be unable to lock the image:
> > 
> > xen be: qdisk-51712: xen be: qdisk-51712: error: Failed to get "write" lock
> > error: Failed to get "write" lock
> > xen be: qdisk-51712: xen be: qdisk-51712: initialise() failed
> > initialise() failed
> > 
> > The proper way to decide if a PV or PVH domU has a qemu-xen running is
> > to use the libxl__need_xenpv_qemu API. But since there is no copy of a
> > libxl_domain_config available in these places, it should be enough to
> > check if xenstore contains the relevant info.
> > 
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> I'm rather sure this patch is repairing the following:
> 
> Tests which are failing intermittently (not blocking):
>  test-amd64-amd64-xl-qemut-debianhvm-amd64 16 guest-localmigrate/x10
> fail pass in 122715
>  test-amd64-amd64-xl-qemuu-debianhvm-amd64 16 guest-localmigrate/x10
> fail pass in 122715

I don't think so. The locking issue is known and fixed (at least for
HVM).  It would cause local migration to fail definitively, while the
log says those two tests fail intermittently.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel