Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 18, 2018 at 09:09:10PM +0200, Olaf Hering wrote:
> Am Fri, 18 May 2018 18:01:42 +0100
> schrieb Wei Liu <wei.liu2@xxxxxxxxxx>:
> 
> > You don't need to test if the guest is HVM anymore. You only need to
> > know if QEMU upstream is running.
> 
> libxl__domain_suspend_device_model handles qemu-xen and qemu-xen-trad.
> That function can not be called unconditionally I think.
> Perhaps I should adjust the commit message.

What I mean is: now you seem to want to call
libxl__domain_suspend_device_model when QEMU upstream is running,
regardless of whether a guest is HVM or PV, so the check for HVM should
be gone.

Does that make sense?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel