Re: [Xen-devel] [PATCH v2 08/10] arm: add a small kconfig for Renesas RCar H3

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 05/22/2018 01:53 AM, Stefano Stabellini wrote:
> This is a reference tiny kconfig for Renesas RCar.  In terms of
> schedulers, it selects credit and NULL only.  It enables all the ARM64
> errata.
It still does not feel right that you select only credit and NULL. Why 
not credit2 and NULL? Or other combination.

> Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: artem_mygaiev@xxxxxxxx
> CC: volodymyr_babchuk@xxxxxxxx
>
> ---
>
> This patch is untested on Renesas RCar, please test!
> Also, I am not sure whether some of the errata workarounds can be
> disabled on the RCar.
>
> Changes in v2:
> - rename to rcar3
> - only add required symbols, let the defauls take care of the rest
I am not sure what you mean here. Your .config below seems contains all 
the options including the non-selected one.
Also, this still not solving the problem raised by Andrew regarding keep 
them updated.
It might be easier to maintain if we provide a per platform config 
option (e.g CONFIG_RCAR3) that will select driver for that specific board.
The user is then free to select other components (e.g scheduler...). So 
you don't impose memaccess disabled, NULL scheduler...
(Thank you Andrii for the suggestion!)

> +# CONFIG_NS16550 is not set
> +# CONFIG_CADENCE_UART is not set
> +# CONFIG_MVEBU is not set
> +# CONFIG_PL011 is not set
> +CONFIG_SCIF=y
> +CONFIG_SMMUv2=y
IIRC the RCAR does not have an SMMU.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel