Re: [Xen-devel] [PATCH] xen: Add fake_s3 command-line option for testing

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.05.18 at 17:33, <george.dunlap@xxxxxxxxxx> wrote:
> On 05/21/2018 03:28 PM, Andrew Cooper wrote:
>> On 21/05/18 15:16, George Dunlap wrote:
>>> Most server-class hardware doesn't support ACPI S3 suspend; but most
>>> bugs we'll run across won't need actual S3 to trigger.  Add a
>>> command-line parameter for a "fake" S3, which will do everything
>>> during suspend/restore except actually calling into the ACPI S3
>>> handler.
>>>
>>> Signed-off-by: Ben Guthro <benjamin.guthro@xxxxxxxxxx>
>>> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
>>> ---
>>> This was originally posted in 2013, but never actually checked in.
>>>
>>> I've removed an extraneous line, and changed the underscore in the
>>> option into a dash (as Jan seems to prefer).
>>>
>>> Compile-tested only.
>>>
>>> If we want osstest to be able to test this functionality it should
>>> probably be backported.
>>>
>>> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
>>> CC: Dario Faggioli <dfaggioli@xxxxxxxx>
>>> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>>> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> 
>> bool_t => bool, drop the redundant initialiser, and you need to patch
>> xen-command-line.markdown.
> 
> Hmm, actually -- would it make more sense to add this as an option to
> acpi_sleep?  e.g., "acpi_sleep=s3_fake"?  (Along with s3_bios and s3_mode?)

+1

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel