Re: [Xen-devel] [PATCH v2 02/10] arm: make it possible to disable more kconfig options

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 22 May 2018, Julien Grall wrote:
> Hi,
> 
> On 05/22/2018 01:53 AM, Stefano Stabellini wrote:
> > Make it possible to disable the following existing kconfig options:
> >    HAS_GICV3
> >    HAS_MEM_ACCESS
> > 
> > Today they are silent option. This patch adds one line descriptions and
> > make them de/selectable.
> > 
> > Also, do not select VIDEO.
> 
> IHMO, this belongs to patch #1.

You are right, I made the change.

> > 
> > Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > 
> > ---
> > Changes in v2:
> > - make HAS_GICv3 depend on ARM_64
> > - remove modifications to ARM_HDLCD kconfig, it has been removed
> > ---
> >   xen/arch/arm/Kconfig | 15 ++++++++++++---
> >   1 file changed, 12 insertions(+), 3 deletions(-)
> > 
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > index cbd9f1b..0b22cfa 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -12,16 +12,13 @@ config ARM_32
> >   config ARM_64
> >     def_bool y
> >     depends on 64BIT
> > -   select HAS_GICV3
> >     config ARM
> >     def_bool y
> >     select HAS_ALTERNATIVE
> >     select HAS_DEVICE_TREE
> > -   select HAS_MEM_ACCESS
> >     select HAS_PASSTHROUGH
> >     select HAS_PDX
> > -   select VIDEO
> >     config ARCH_DEFCONFIG
> >     string
> > @@ -43,6 +40,18 @@ config ACPI
> >     config HAS_GICV3
> >     bool
> > +   prompt "GICv3 driver"
> > +   depends on ARM_64
> > +   default y
> > +
> > +config HAS_MEM_ACCESS
> > +   bool
> > +   prompt "Memory Access and VM events"
> > +   default y
> > +   ---help---
> > +
> > +     Framework to configure memory access types for guests and receive
> > +     related events in userspace.
> 
> See my reply on v1 of this patch.

I replied there. I would prefer to keep it. At least, I would like to do
the renaming of HAS_MEM_ACCESS to MEM_ACCESS as part of this series to
make my work easier.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel