Re: [Xen-devel] [PATCH] tools/kdd: alternative way of muting spurious gcc warning

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, May 23, 2018 at 10:28:47AM +0200, Marek Marczykowski-Górecki wrote:
> On Wed, May 23, 2018 at 08:48:12AM +0100, Wei Liu wrote:
> > On Tue, May 22, 2018 at 09:47:45PM +0200, Marek Marczykowski-Górecki wrote:
> > > Older gcc does not support #pragma GCC diagnostics, so use alternative
> > > approach - change variable type to uint32_t (this code handle 32-bit
> > > requests only anyway), which apparently also avoid gcc complaining about
> > > this (otherwise correct) code.
> > > 
> > > Fixes 437e00fea04becc91c1b6bc1c0baa636b067a5cc "tools/kdd: mute spurious
> > > gcc warning"
> > > 
> > > Signed-off-by: Marek Marczykowski-Górecki 
> > > <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > 
> > I'm confused. Do we still need this? Gcc 8.1 seems to have fixed the bug
> > which caused compilation failure.
> 
> Apparently not entirely - see my other email. It still fails on Fedora
> 28 with gcc 8.1.
> 

Oh I missed that, sorry.

In that case we should take this patch instead:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel