Re: [Xen-devel] [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

[Sameer Goel <sameer.goel@xxxxxxxxxx>]

On 05/24/2018 01:57 AM, Jan Beulich wrote:
> > > > On 24.05.18 at 02:46, <sameer.goel@xxxxxxxxxx> wrote:
> > --- /dev/null
> > +++ b/xen/include/xen/linux_compat.h
> I continue to dislike the idea of having a header with these contents in this 
> location.
As explained previously this header can be used for the any driver that 
we want to port from Linux. This is not arm specific. This seemed like 
the best location for the file. Which other common location should I pick?
> Independent of that I'd prefer if new files used hyphens instead of underscores
I'll change the name of the file.
> in their names - just like for command line options, other than C identifiers 
> they're
> not restricted to a very narrow set of possible delimiters or name components.
>
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel