Re: [Xen-devel] [v2 4/6] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 25/05/18 05:41, Manish Jaggi wrote:
> On 05/25/2018 01:59 AM, Sameer Goel wrote:
> > On 05/23/2018 10:48 PM, Manish Jaggi wrote:
> > > Hi Sameer,
> > >
> > > General Comment, please use appropriate variable names for XXX_domain 
> > > structures in code which is xen specific.
> > I thought that we had discussed this before on one of the RFCs.
> Yes and no one replied to my last comment that the var names have to be 
> non confusing in Xen specific code.
Rather than just saying "you haven't replied to my last comment", how 
about giving a pointer to that e-mail?
AFAICT, the last answer was a reply from me to your e-mail. As I wrote 
there if it is used by Xen only code, then it should be alright. But 
Linux code *should not* be changed.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel