Re: [Xen-devel] [PATCH] xen/svm: don't clear interception for MSRs required for introspection

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 05/25/2018 06:19 PM, Boris Ostrovsky wrote:
> On 05/25/2018 08:38 AM, Razvan Cojocaru wrote:
>> This patch mirrors the VMX code that doesn't allow
>> vmx_disable_intercept_for_msr() 
> 
> vmx_clear_msr_intercept() ?
> 
>> to clear interception of MSRs that
>> an introspection agent is trying to monitor.
>>
>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> 
> With that fixed,
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

Apologies, you're right. I was looking at the original patch, where
there's vmx_disable_intercept_for_msr():

https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=490a39a1dbc7406776344f36e1b27c33c2ada63d

I'll submit V2 with that corrected (unless it's preferrable for that to
be changed on commit?).


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel