Re: [Xen-devel] [PATCH 2/6] x86: Improvements to ler debugging

["Jan Beulich" <JBeulich@xxxxxxxx>]

 >>> On 28.05.18 at 16:27, <andrew.cooper3@xxxxxxxxxx> wrote:
> * Command line documentation for what the option does.
>  * Implement a canonicalise_addr() helper and replace the opencoded use in
>    sign_extend_msr()
>  * Canonicalise the ler pointers and print symbol information.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:

> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1245,6 +1245,12 @@ if left disabled by the BIOS.
>  ### ler (x86)
>  > `= <boolean>`
>  
> +> Default: 0

Perhaps better `false`?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel