Re: [Xen-devel] [PATCH v3 5/8] hvm/mtrr: use the hardware number of variable ranges for Dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.05.18 at 17:40, <roger.pau@xxxxxxxxxx> wrote:
> @@ -448,6 +460,9 @@ bool_t mtrr_var_range_msr_set(
>      uint64_t *var_range_base = (uint64_t*)m->var_ranges;
>  
>      index = msr - MSR_IA32_MTRR_PHYSBASE(0);
> +    if ( (index / 2) >= MASK_EXTR(m->mtrr_cap, MTRRcap_VCNT) )
> +        return 0;

I think this would better go into hvm_msr_write_intercept(), paralleling
the hvm_msr_read_intercept() adjustment you make. There might be an
ASSERT() warranted here (the other caller is hvm_load_mtrr_msr(),
which by now has suitable checking in place afaict).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel