[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/5] x86: split out cpuid objects and helpers

>>> On 24.05.18 at 18:05, <wei.liu2@xxxxxxxxxx> wrote:
> They are moved to a new header which is going to be consumed by both
> the hypervisor and toolstack.

By the end of this series it is not clear what use all of the moved stuff is 
to be to the tool stack. Can we move things as they are indeed gaining a 2nd

> Create a new directory for this kind of headers in anticipation of
> more will come.

I prefer Roger's suggestion to follow more the libelf style of sharing bits.

>  xen/include/asm-x86/arch-shared/cpuid.h | 213 
> ++++++++++++++++++++++++++++++++
>  xen/include/asm-x86/cpuid.h             | 210 +------------------------------

And if this was the way to go, I further dislike something like arch-*/
underneath asm-*/. How about xen/include/shared/x86/cpuid.h?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.