Re: [Xen-devel] [PATCH v3 10/10] xen: add cloc target

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 29 May 2018, Jan Beulich wrote:
> >>> On 23.05.18 at 02:25, <sstabellini@xxxxxxxxxx> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -267,3 +267,14 @@ $(KCONFIG_CONFIG):
> >  include/config/auto.conf.cmd: ;
> >  
> >  -include $(BASEDIR)/include/config/auto.conf.cmd
> > +
> > +.PHONY: cloc
> > +cloc:
> > +   $(eval tmpfile := $(shell mktemp))
> > +   $(foreach f, $(shell find $(BASEDIR) -name *.o.d), \
> > +           $(eval path := $(dir $(f))) \
> > +           $(eval name := $(shell cat $(f) | head -1 | cut -d " " -f 2)) \
> > +           $(shell if test -f $(path)/$(name) ; then echo $(path)/$(name) 
> > >> $(tmpfile); fi;))
> > +   cloc --list-file=$(tmpfile)
> > +   rm $(tmpfile)
> 
> I thought I had said so on v2 already, but it looks like I remember a mail I
> had mostly finished when my mail frontend decided to kick me off. So I'm
> sorry for mentioning this only now: xen/arch/x86/x86_64/.mm.o.d (just
> to give an example has
> 
> x86_64/mm.o: x86_64/mm.c \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/xen/config.h \
> ...
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/asm/mem_paging.h \
>  x86_64/compat/mm.c \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/xen/event.h \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/xen/softirq.h \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/asm/softirq.h \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/asm/event.h \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/compat/memory.h \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/compat/physdev.h \
>  /build/xen/unstable-hg/2018-05-28-64bit/xen/include/asm/pv/mm.h
> 
> I think you'd better count x86_64/compat/mm.c's lines too.

Thank you for noticing this, I'll make sure to handle this case too

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel