Re: [Xen-devel] [PATCH v4 01/10] xen/arm64: Added handling of the trapped access to OSLSR register

[Julien Grall <julien.grall@xxxxxxx>]

Hi Mirela,

On 30/05/18 10:53, Mirela Simonovic wrote:
> On Wed, May 30, 2018 at 11:48 AM, Mirela Simonovic 
> <mirela.simonovic@xxxxxxxxxx <mailto:mirela.simonovic@xxxxxxxxxx>> wrote:
> Please note - I'm not sure how should write to this register be treated. 
> In the original patch (handle_ro_raz implementation) undef exception 
> will be raised. I realized in what I proposed that wouldn't be the case, 
> it's a write-ignore.
I think you want to keep the inject_undef_exception here to stay 
consistent with the rest of RO register implementation. I would suggest 
to create a new helper handle_ro_read_val(...) that will take the value 
to return in parameter.
handle_ro_raz could then be implemented using the new helper.

Also, I would prefer if you use 1 << 3 as it is clearer that bit 3 is set.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel