Re: [Xen-devel] [PATCH v4 10/10] xen: add per-platform defaults for NR_CPUS

[Julien Grall <julien.grall@xxxxxxxxx>]

Hi,

Sorry for the formatting. I am pretty sure you need to CC "THE REST" here.

On Thu, 31 May 2018, 22:50 Stefano Stabellini, <sstabellini@xxxxxxxxxx> wrote:

Add specific per-platform defaults for NR_CPUS. Note that the order of
the defaults matter: they need to go first, otherwise the generic
defaults will be applied.

This is done so that Xen builds customized for a specific hardware
platform can have the right NR_CPUS number.

Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: JBeulich@xxxxxxxx
CC: andrew.cooper3@xxxxxxxxxx
---
 xen/arch/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig
index cf0acb7..d451eb8 100644
--- a/xen/arch/Kconfig
+++ b/xen/arch/Kconfig
@@ -2,6 +2,9 @@
 config NR_CPUS
        int "Maximum number of physical CPUs"
        range 1 4095
+       default "8" if ARM && RCAR3
+       default "4" if ARM && QEMU
+       default "4" if ARM && MPSOC
        default "256" if X86
        default "128" if ARM
        ---help---

IMHO, it would make sense to move this option in the arch/{arm,x86)/Kconfig.

But I am not sure how this will work as with this series you can select multiple platforms in on Kconfig. What will be the end result?

Anyway, as I mention the way to go is a option list with only one possible choice.

Cheers,

--
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel