Re: [Xen-devel] [PATCH v4 04/10] Make MEM_ACCESS configurable

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 1 Jun 2018, Jan Beulich wrote:
> >>> On 31.05.18 at 23:48, <sstabellini@xxxxxxxxxx> wrote:
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -20,8 +20,16 @@ config HAS_DEVICE_TREE
> >  config HAS_EX_TABLE
> >     bool
> >  
> > -config HAS_MEM_ACCESS
> > -   bool
> > +config MEM_ACCESS_ALWAYS_ON
> > +   def_bool n
> 
> Only "bool" please - there should be no defaults other than y for options 
> without
> prompts. Otherwise, if later an option gains a prompt, the user won't be
> presented with the option to enable it when using one of the *oldconfig 
> targets
> (due to the previously recorded setting).

done


> With that replaced
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> also in case you follow Tamas'es suggestion and switch ...
> 
> > +config MEM_ACCESS
> > +   def_bool y
> > +   prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
> 
> ... the default here to MEM_ACCESS_ALWAYS_ON (or !ARM or X86).

I changed it to:

  config MEM_ACCESS
    def_bool y if MEM_ACCESS_ALWAYS_ON
    prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON


Thank you, I'll add your acked.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel