[Xen-devel] [OSSTEST PATCH] sg-report-flight: When justifying, disregard out-of-flight build jobs

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

When we are looking for a previous job which justifies a failure, we
need to check that the putative justifying job used the same revision
as the baseline we are judging against.  So we investigate the build
jobs referred to by that putative justifying job.

However, there are cases where this is not appropriate.  Currently,
the most obvious example is freebsdbuildjob.

The freebsd arrangements involve referencing an anointed
freebsdbuildjob, which was in turn built from a previous
freebsdbuildjob, eventually terminating in some kind of ad-hoc job.
We would not want to investigate all of those even if we were trying
to analyse a flight on a freebsd branch.

The real thing we want to check that the build jobs *in the same
flight as the justifying job* used the right revisions.  Build jobs
from other flights were either (i) build jobs for components not being
targed for testing by this branch, but which were necessary for the
justifying job and for which we decided to reuse another build job
(in which case we don't really care what versions they used, even
if underlying it all there might be a different version of a tree
we are actually interested in (ii) the kind of continuous update
thing seen with freebsdbuildjob.

There is no corresponding issue with cs-bisection-step, because it
only looks for the *buildjob runvars of the test it is actually
interested in, and does not recurse.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 sg-report-flight | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sg-report-flight b/sg-report-flight
index 2f5c391..a1adf95 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -258,6 +258,7 @@ END
        while (@binfos_todo) {
            my ($why,$bflight,$bjob) = @{ shift @binfos_todo };
            next if $binfos{$bflight}{$bjob};
+            next unless $bflight == $tflight;
            $binfos{$bflight}{$bjob} = $why;
            $buildjobsq->execute($bflight,$bjob);
            $binfos_queue->($bflight,$buildjobsq,$why);
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel