Re: [Xen-devel] [PATCH 1/3] xen/kbdif: Move multi-touch device parameters to backend nodes

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, May 23, 2018 at 09:19:21AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> 
> In current kbdif protocol definition multi-touch device parameters
> are described as a part of frontend's XenBus configuration nodes while
> they belong to backend's configuration. Fix this by moving
> the parameters to the proper section.
> 
> Fixes: b7a3ce49d528 ("xen/kbdif: add multi-touch support")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> Reported-by: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Juergen, you OK if I check this in?

> ---
>  xen/include/public/io/kbdif.h | 38 +++++++++++++++++------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> index 23d1f70d5210..a68da0f1a37f 100644
> --- a/xen/include/public/io/kbdif.h
> +++ b/xen/include/public/io/kbdif.h
> @@ -96,6 +96,25 @@
>   *      Maximum Y coordinate (height) to be used by the frontend
>   *      while reporting input events, pixels, [0; UINT32_MAX].
>   *
> + *----------------------- Multi-touch Device Parameters 
> ----------------------
> + *
> + * multi-touch-num-contacts
> + *      Values:         <uint>
> + *
> + *      Number of simultaneous touches reported.
> + *
> + * multi-touch-width
> + *      Values:         <uint>
> + *
> + *      Width of the touch area to be used by the frontend
> + *      while reporting input events, pixels, [0; UINT32_MAX].
> + *
> + * multi-touch-height
> + *      Values:         <uint>
> + *
> + *      Height of the touch area to be used by the frontend
> + *      while reporting input events, pixels, [0; UINT32_MAX].
> + *
>   
> *****************************************************************************
>   *                            Frontend XenBus Nodes
>   
> *****************************************************************************
> @@ -143,25 +162,6 @@
>   *
>   *      OBSOLETE, not recommended for use.
>   *      PFN of the shared page.
> - *
> - *----------------------- Multi-touch Device Parameters 
> -----------------------
> - *
> - * multi-touch-num-contacts
> - *      Values:         <uint>
> - *
> - *      Number of simultaneous touches reported.
> - *
> - * multi-touch-width
> - *      Values:         <uint>
> - *
> - *      Width of the touch area to be used by the frontend
> - *      while reporting input events, pixels, [0; UINT32_MAX].
> - *
> - * multi-touch-height
> - *      Values:         <uint>
> - *
> - *      Height of the touch area to be used by the frontend
> - *      while reporting input events, pixels, [0; UINT32_MAX].
>   */
>  
>  /*
> -- 
> 2.17.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel