Re: [Xen-devel] [PATCH 3/3] tools/libxc: retry hypercall in case of EFAULT

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Juergen Gross writes ("Re: [Xen-devel] [PATCH 3/3] tools/libxc: retry hypercall 
in case of EFAULT"):
> On 15/06/18 16:54, Andrew Cooper wrote:
> > Probably a very minor issue, but is it worth caching never_fault once
> > when opening the xc_interface?  Calling into a separate shared object on
> > every domctl isn't the height of efficiency.
> 
> Via a global variable or by extending struct xc_interface_core? Ian?

I think this is a very minor point.  Are domctls really a hot path ?
A cross-shared-library call is a very minor overhead.

If this is to be done, it should not be a global variable.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel