Re: [Xen-devel] Ping: [PATCH 2/2] x86/HVM: attempts to emulate FPU insns need to set fpu_initialised

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 22 June 2018 11:53
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; xen-devel <xen-
> devel@xxxxxxxxxxxxxxxxxxxx>; Juergen Gross <jgross@xxxxxxxx>
> Subject: Ping: [PATCH 2/2] x86/HVM: attempts to emulate FPU insns need to
> set fpu_initialised
> 
> >>> On 15.06.18 at 10:58, <JBeulich@xxxxxxxx> wrote:
> > My original way of thinking here was that this would be set anyway at
> > the point state gets reloaded after the adjustments hvmemul_put_fpu()
> > does, but the flag should already be set before that - after all the
> > guest may never again touch the FPU before e.g. getting migrated/saved.
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > --- a/xen/arch/x86/hvm/emulate.c
> > +++ b/xen/arch/x86/hvm/emulate.c
> > @@ -2053,6 +2053,7 @@ static int hvmemul_get_fpu(
> >           * masking of all exceptions by FNSTENV.)
> >           */
> >          save_fpu_enable();
> > +        curr->fpu_initialised = true;
> >          curr->fpu_dirtied = true;
> >          if ( (fpu_ctxt->fcw & 0x3f) != 0x3f )
> >          {
> 

Apologies for the delay...

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel