Re: [Xen-devel] [PATCH v2 1/8] xen: calculate XEN_BUILD_TIME using XEN_BUILD_DATE value

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.06.18 at 16:35, <daniel.kiper@xxxxxxxxxx> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -9,7 +9,7 @@ export XEN_FULLVERSION   = 
> $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
>  export XEN_WHOAMI    ?= $(USER)
>  export XEN_DOMAIN    ?= $(shell ([ -x /bin/dnsdomainname ] && 
> /bin/dnsdomainname) || ([ -x /bin/domainname ] && /bin/domainname || echo 
> [unknown]))
>  export XEN_BUILD_DATE        ?= $(shell LC_ALL=C date)
> -export XEN_BUILD_TIME        ?= $(shell LC_ALL=C date +%T)
> +export XEN_BUILD_TIME        ?= $(shell LC_ALL=C date -d '$(XEN_BUILD_DATE)' 
> +%T)

Nice idea, but I'm not sure we can rely on the non-standard -d
option to be supported by all environments Xen may be built in.
As per
http://pubs.opengroup.org/onlinepubs/007904975/utilities/date.html
the only standard option supported by date is -u. Assuming C and
POSIX locales produce the same standard format, I'm afraid you may
need to resort to sed-ery to achieve what you want.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel