Re: [Xen-devel] [PATCH v2 3/6] libxc: allow HVM guest to have modules

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jun 25, 2018 at 05:58:52PM +0200, Roger Pau Monné wrote:
> On Mon, Jun 25, 2018 at 12:35:30PM +0100, Wei Liu wrote:
> > Lift the loading code out of PVH specific branch. Take the chance to
> > make the debug message more useful.
> 
> Would be nice to mention that you also account for virt_base being
> unset. 

NP.

> >  
> > +    for ( i = 0; i < dom->num_modules; i++ )
> > +    {
> > +        struct xc_hvm_firmware_module mod;
> > +        uint64_t base = dom->parms.virt_base != UNSET_ADDR ?
> > +            dom->parms.virt_base : 0;
> 
> For PVH/HVM virt_base should always be UNSET_ADDR and vstart/vend
> should be a physical address (ie: rename to pstart/pend). I guess
> other bits of the code already use virt_base if present so we need to
> use it here to in order to compensate.

The other half is PV code which relies on vstart for proper placement.
Note this snippet is now common to all guest types.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel