Re: [Xen-devel] [PATCH] gnttab: silence table expansion message

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.18 at 13:14, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/06/18 08:22, Jan Beulich wrote:
>> This currently shows up for basically every domain, when originally it
>> was logged only when going beyond the default table size. Restore that
>> behavior.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -1764,9 +1764,10 @@ gnttab_grow_table(struct domain *d, unsi
>>          req_nr_frames = INITIAL_NR_GRANT_FRAMES;
>>      ASSERT(req_nr_frames <= gt->max_grant_frames);
>>  
>> -    gdprintk(XENLOG_INFO,
>> -            "Expanding d%d grant table from %u to %u frames\n",
>> -            d->domain_id, nr_grant_frames(gt), req_nr_frames);
>> +    if ( req_nr_frames > INITIAL_NR_GRANT_FRAMES )
>> +        gdprintk(XENLOG_INFO,
>> +                 "Expanding d%d grant table from %u to %u frames\n",
>> +                 d->domain_id, nr_grant_frames(gt), req_nr_frames);
> 
> This has been on my todo list for a while, but I'd go one stage further
> and delete it fully.
> 
> Domains either never trigger it, or expand to max.  It doesn't provide
> any useful information at all.

I disagree - domains don't normally use all or nothing of grant tables.
And this (being a debug message only) may be a useful hint if a
domain not expected to use all of its grant table suddenly grows its
size significantly.

My main goal here really is to get rid of the 0 -> 1 transition message
(when starting a guest).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel