Re: [Xen-devel] [PATCH 4/6] x86/msr: Clean up the MSR_FEATURE_CONTROL constants

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.18 at 19:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/06/18 14:18, Andrew Cooper wrote:
>>  xen/arch/x86/cpu/mwait-idle.c       |  4 ++--
> 
> I forgot to say that this patch as shown may impact the ease of taking
> new code from Linux.

The diffstat above doesn't suggest this is going to make things more
complicated. We're already far from being able to take Linux commits
verbatim.

> While we don't want to proliferate the broken APIs of the current
> rdmsr() infrastructure, one option we could do is to introduce a
> <xen/linux-compat.h> file for including into code from Linux, to ease
> the differences.

See the other (ARM related) thread where they also want to introduce
such a header: I'm not really fancying something like this becoming
globally visible.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel