Re: [Xen-devel] [PATCH 3/3] libxc: do not return a value from xc_cpuid_policy

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Jun 28, 2018 at 08:31:49AM +0100, Wei Liu wrote:
> On Thu, Jun 28, 2018 at 09:29:32AM +0200, Roger Pau Monné wrote:
> > On Wed, Jun 27, 2018 at 03:49:30PM +0100, Wei Liu wrote:
> > > On Wed, Jun 27, 2018 at 04:32:14PM +0200, Roger Pau Monne wrote:
> > > > None of the called functions return any errors, so there's no point in
> > > > returning an int from xc_cpuid_policy.
> > > > 
> > > > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > > 
> > > What is the plan for this function? I expect it (and its children) to go
> > > away soon?
> > 
> > This is likely to go away with further cpuid work.
> > 
> > > You can also delete xch, I think. It is not used.
> > 
> > Right, I left it because all the xc_cpuid_* take xch as the first
> > parameter. If I remove it here I will have to remove it from the
> > _intel, _amd, _hvm and _pv helpers.
> 
> If this and its leaf functions are going away soon-ish I'm fine with
> less code churn.

Hm, I'm not removing all of them, so let me add another patch on top
of this one to remove the xch parameter.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel