[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 03/15] xen/arm: extend device tree based multiboot protocol

Hi Stefano,

On 02/07/18 22:31, Stefano Stabellini wrote:
On Thu, 14 Jun 2018, Julien Grall wrote:
On 13/06/18 23:15, Stefano Stabellini wrote:
+- cpus (optional)
+    A string specifying the number of vcpus to allocate to the guest. If
+    not specified it defaults to "1".

Same remarks as for "mem".

I think it would be nicer if we kept the same format used for xl config
files for these two options.Especially given that we already have the
functions in the hypervisor to parse them (Xen knows how to parse
dom0_max_vcpus and dom0_mem for instance). It is going to be easier to > use 
and it doesn't come with a cost for Xen.

I can't see any reason to keep those 2 options similar to libxl when all the rest is embracing DT format. The user would already have to spend some times to look at the new bindings anyway, not using string is not going to be a big difficulty.

While I agree that Xen knows how to parse dom0_mem, dom0_max_vcpus, Xen also knows how to read numbers from cells which is widely used within the hypervisor. So both solution are going to be easy to use in the hypervisor. However, the former is always going to be faster, less error prone than the latter.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.