[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] osstest: remove duplicate set_freebsd_runvars

On Tue, Jul 03, 2018 at 05:53:44PM +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH 1/3] osstest: remove duplicate 
> set_freebsd_runvars"):
> > On Tue, Jul 03, 2018 at 04:10:56PM +0100, Ian Jackson wrote:
> > > Roger Pau Monne writes ("[PATCH 1/3] osstest: remove duplicate 
> > > set_freebsd_runvars"):
> > > > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > > 
> > > Oops.  I wonder if this was my doing.  Have you verified that they're
> > > identical ?
> > 
> > They are not identical. The one in mfi-common is a superset of the one
> > here, because the function itself will try to retrieve the anointed
> > version itself as a last resort.
> So as a side effect of this change you are adding that functionality
> to make-freebsd-flight ?  Or rather, you are fixing, in
> make-freebsd-flight, the bug that caused me to write:
>   mfi-common: Fall back to anointed builds in Executive mode
> ?

For make-freebsd-flight the initial build to use is set by
cr-daily-branch, so that we can have FreeBSD flights from different
FreeBSD branches. I think this behaviour should be preserved, even if
ATM we only run FreeBSD flights from the master branch.

So I don't think this is strictly a bug for make-freebsd-flight, but
there's no need to have a specific set_freebsd_runvars.

Does this make sense? Should I add something to the commit message in
order to make this clearer? What about:

"The set_freebsd_runvars helper in mfi-common is a superset of the
original function present in make-freebsd-flight, and will attempt to
fetch the last anointed FreeBSD build as a last resort option if no
FreeBSD build is signaled from the FreeBSD env vars. There's no
reason to have this duplication, since the set_freebsd_runvars in
mfi-common is perfectly suitable to be used by make-freebsd-flight.

This duplication was wrongly introduced by d36a7d892f by adding a
set_freebsd_runvars to mfi-common without removing the original
function in make-freebsd-flight."

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.