Re: [Xen-devel] [PATCH 3/3] osstest: add FreeBSD Xen build job

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Jul 03, 2018 at 05:56:51PM +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH 3/3] osstest: add FreeBSD Xen build job"):
> > On Tue, Jul 03, 2018 at 04:22:45PM +0100, Ian Jackson wrote:
> > > This is quite ugly.  sg-run-job normally tries to be a bit more
> > > abstract.  I'm not sure exactly what to suggest.
> > > 
> > > Maybe a ts-xen-build-clang containing these arguments ?  Of course for
> > > a clang build on Linux /usr/local/bin/ld is wrong...
> > 
> > Maybe ts-xen-build-freebsd?
> > 
> > I went this route because it did not involve creating yet another
> > ts-build-* script, but if you think it's better I can add such a
> > script.
> 
> Mmm.  How about a simple shell script wrapper ?  See
> ts-host-install-twice :-).
> 
> > It happens to be like that in this case because the
> > ts-build-prep-freebsd installs the binutils package in /usr/local and
> > that provides GNU ld in the specified path.
> 
> So this is a thing specific to building on FreeBSD, and will always be
> true ?

Yes, I think on FreeBSD we can assume that /usr/local/bin/ld will
always be GNU ld iff the binutils package has been installed from
ports.

> Presumably on other BSDs too in theory ?

Hm, I wouldn't bet on that. NetBSD still ships GNU ld in base, and the
ports directory there is /usr/pkg/ by default IIRC. I'm not sure about
OpenBSD.

The only common part is the fact that all BSDs ship BSD make in base,
and GNU make is gmake, so I'm happy to place this in ts-xen-build
directly (like it's done in patch #2).

> Maybe it should be in ts-xen-build, then, conditional on $ho->{OS} ?

I think I prefer to use a ts-xen-build-freebsd wrapper around
ts-xen-build if you are OK with it.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel