Re: [Xen-devel] [PATCH] x86/altp2m: Add a subop for obtaining the mem access of a page

[Adrian Pop <apop@xxxxxxxxxxxxxxx>]

Hello,

On Mon, Jul 02, 2018 at 12:01:01PM +0100, Julien Grall wrote:
> Hi,
> 
> On 06/28/2018 02:00 PM, Adrian Pop wrote:
> > diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c
> > index ae2686ffa2..ba9e50e7f6 100644
> > --- a/xen/arch/arm/mem_access.c
> > +++ b/xen/arch/arm/mem_access.c
> > @@ -236,7 +236,7 @@ bool p2m_mem_access_check(paddr_t gpa, vaddr_t gla, 
> > const struct npfec npfec)
> >       if ( !p2m->mem_access_enabled )
> >           return true;
> > -    rc = p2m_get_mem_access(v->domain, gaddr_to_gfn(gpa), &xma);
> > +    rc = p2m_get_mem_access(v->domain, gaddr_to_gfn(gpa), &xma, 0);
> >       if ( rc )
> >           return true;
> > @@ -440,8 +440,9 @@ long p2m_set_mem_access_multi(struct domain *d,
> >       return -EOPNOTSUPP;
> >   }
> > +/* The altp2m_idx argument is not used on ARM. */
> 
> s/ARM/Arm/ please.
> 
> Also, I guess altp2m_idx should always be 0 until altp2m is implemented for
> Arm. If so, I would like to see a check on the variable and return -EINVAL
> on error.

All right.  Thank you!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel