Re: [Xen-devel] [PATCH] osstest: limit FreeBSD jobs to hardware booting in BIOS mode

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH] osstest: limit FreeBSD jobs to hardware 
booting in BIOS mode"):
> There's no support yet in osstest to install FreeBSD from UEFI, so for
> the time being limit the FreeBSD jobs to boxes booting with legacy
> BIOS.

Surely this can't be right, because it only touches
make-freebsd-flight.  I think this change needs to be in
set_freebsd_runvars.

> diff --git a/make-freebsd-flight b/make-freebsd-flight
> index 64dfe9a6..8122c2eb 100755
> --- a/make-freebsd-flight
> +++ b/make-freebsd-flight
> @@ -75,7 +75,7 @@ for arch in "$arches"; do
>                  $arch_runvars                                   \
>                  tree_freebsd=$TREE_FREEBSD                      \
>                  revision_freebsd=$REVISION_FREEBSD              \
> -                host_hostflags=arch-$arch,purpose-build         \
> +                
> host_hostflags=arch-$arch,purpose-build,PropEq:Firmware:bios:bios \
>                  all_host_os=freebsd                             \
>                  $freebsd_runvars
>  
> @@ -87,7 +87,7 @@ for arch in "$arches"; do
>                  $arch_runvars                                   \
>                  tree_freebsd=$TREE_FREEBSD                      \
>                  revision_freebsd=$REVISION_FREEBSD              \
> -                host_hostflags=arch-$arch,purpose-build         \
> +                
> host_hostflags=arch-$arch,purpose-build,PropEq:Firmware:bios:bios \
>                  all_host_os=freebsd                             \
>                  freebsdbuildjob=build-$arch-freebsd

Also IMO this demonstrates that before accepting this code I ought to
have asked you to mostly-unify these two mostly-identical calls to
job_create_build.  Ah well.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel